Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint/BooleanSymbol is not safe to auto-correct #7936

Closed
laurmurclar opened this issue May 7, 2020 · 0 comments · Fixed by #7941
Closed

Lint/BooleanSymbol is not safe to auto-correct #7936

laurmurclar opened this issue May 7, 2020 · 0 comments · Fixed by #7941

Comments

@laurmurclar
Copy link
Contributor

Description

Lint/BooleanSymbol is marked as safe to auto-correct, but replacing :true with true will almost certainly break code that relies on it being :true. They are not equivalent.

I can make a PR to update it today, but wanted to have an issue in place first

RuboCop version

$  bundle exec 'rubocop -V'
0.82.0 (using Parser 2.7.1.2, running on ruby 2.6.5 x86_64-darwin19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #7936] Mark as Lint/BooleanSymbol unsafe
1 participant
@laurmurclar