Conflict between Lint/RedundantCopDisableDirective and Lint/SuppressedException

[olliebennett]

My previously valid usage of # rubocop:disable Lint/SuppressedException is being flagged by the Lint/RedundantCopDisableDirective cop. Upon removing the rubocop:disable, the Lint/SuppressedException cop raises a violation again.

---

Expected behavior

My usage of rubocop:disable should not be flagged as a Lint/RedundantCopDisableDirective; it seems to be legitimately disabling the Lint/SuppressedException cop.

Actual behavior

My usage of rubocop:disable is flagged.

Steps to reproduce the problem

Create the file spec/dummy_spec.rb;

RSpec.describe Dummy do
  it 'dummy spec' do
    # This rescue is here to ensure the test does not fail because of the `raise`
    # rubocop:disable Lint/SuppressedException
    expect { begin subject; rescue ActiveRecord::Rollback; end }.not_to(change(Post, :count))
    # rubocop:enable Lint/SuppressedException
  end
end

Run RuboCop on the file and observe output;

➜ bundle exec rubocop spec/dummy_spec.rb
spec/dummy_spec.rb:4:5: W: Lint/RedundantCopDisableDirective: Unnecessary disabling of Lint/SuppressedException.                                                              
    # rubocop:disable Lint/SuppressedException
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 1/1 file |====================================================================== 100 ======================================================================>| Time: 00:00:00 

1 file inspected, 1 offense detected

Edit the file (to remove the apparently invalid rubocop:disable and rubocop:enable) as follows;

RSpec.describe Dummy do
  it 'dummy spec' do
    # This rescue is here to ensure the test does not fail because of the `raise`
    expect { begin subject; rescue ActiveRecord::Rollback; end }.not_to(change(Post, :count))
  end
end

Re-run RuboCop as before;

➜ bundle exec rubocop spec/dummy_spec.rb
spec/dummy_spec.rb:4:29: W: Lint/SuppressedException: Do not suppress exceptions.                                                                                             
    expect { begin subject; rescue ActiveRecord::Rollback; end }.not_to(change(Post, :count))
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 1/1 file |====================================================================== 100 ======================================================================>| Time: 00:00:00 

1 file inspected, 1 offense detected

RuboCop version

This has occurred since updating to RuboCop 0.81, and continues in RuboCop 0.82. It did not occur for RuboCop 0.80. Haven't had a chance to bisect the exact commit where it was introduced (but happy to if the cause isn't clear).

➜ bundle exec rubocop -V
0.82.0 (using Parser 2.7.1.1, running on ruby 2.7.0 x86_64-darwin18)