Have correctors accept node instead of range #7863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
force-pushed
the
correct_node
branch
2 times, most recently
from
5ee7276
to
a363f15
Compare
|
Might be a good idea to also mention this in the docs. |
I modified slightly I amended the PR with simplifications using this (mostly due to accepting node, a few using |
Provide better errors in case of wrong argument Before: "undefined method `source_buffer' for 1..3:Range" After: "Expected a Parser::Source::Range or Rubocop::AST::Node, got Range"
|
Nicely done! 🙇♂️ |
pftg
added a commit
to jetthoughts/erb-lint
that referenced
this pull request
May 22, 2020
Rubocop changed interface and after rubocop/rubocop#7863 it requires correctors to accept nodes. Closes Shopify#162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows correctors to accept nodes in addition to ranges.
E.g:
corrector.insert_before(node, 'blah')Also provides better errors in case of wrong argument
Before: "undefined method `source_buffer' for 1..3:Range"
After: "Expected a Parser::Source::Range or Rubocop::AST::Node, got Range"
I don't think it would be particularly useful, but we could actually accept ranges like
1..3if we wanted too...This assumes #7862 is merged.