Add option to allow case equality when the receiver is a constant #7861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
force-pushed
the
rm-allow-constant-receiver-case-equality
branch
3 times, most recently
from
bf2204a
to
ebbe68c
Compare
For some constant, specially direct subclasses of `BasicObject`, using `is_a?` is not an option since `BasicObject` doesn't respond to that method. In those cases it would be interesting to allow this config so apps can opt-out that cop only when the receiver is a constant.
rafaelfranca
force-pushed
the
rm-allow-constant-receiver-case-equality
branch
from
ebbe68c
to
c48064f
Compare
|
I like the suggested change. Thanks! 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some constant, specially direct subclasses of
BasicObject, usingis_a?is not an option sinceBasicObjectdoesn't respond to that method.In those cases it would be interesting to allow this config so apps can opt-out that cop only when the receiver is a constant.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.