[Fix #7728] Fix an error for Style/OneLineConditional

[koic]

Fixes #7728.

This PR fixes an error for Style/OneLineConditional when one of the branches contains a self keyword.

---

Before submitting the PR make sure the following are checked:

• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

[Drenmi]

Can you point me to the code that calls #arguments? on a self node? I think the call site probably should filter the relevant nodes instead. I can have a look. 🙂

[koic]

SelfNode#arguments? is called in the following code.
https://github.com/rubocop-hq/rubocop/blob/v0.80.0/lib/rubocop/cop/style/one_line_conditional.rb#L96

I was worried about choosing between implementing SelfNode#arguments? or guarding the above with resopnd_to(:arguments?).

  def keyword_with_changed_precedence?(node)
    return false unless node.keyword?
    return true if node.prefix_not?

-   node.arguments? && !node.parenthesized_call?
+   node.respond_to?(:arguments?) && node.arguments? && !node.parenthesized_call?
  end

[Drenmi]

@koic Let me have a look. 🙂 Ideally we shouldn't do any of those. We should make sure incompatible nodes don't reach this code.

[tas50]

@koic Any chance this one can get merged so I can do testing on my side?

[koic]

@Drenmi Can we merge this PR to resolve the error first?

[Drenmi]

@koic Yes! Please go ahead. I don't have time to look into it for another couple of weeks or so. 🙂

[koic]

I get it. Thank you for taking your time!