[Fix #7716] Fix an infinite loop error for Style/TernaryParentheses
#7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theses` Fix rubocop#7716. This PR fixes an infinite loop error for `Style/TernaryParentheses` with `Style/RedundantParentheses` when using `EnforcedStyle: require_parentheses_when_complex`. ```ruby # example.rb !foo.nil? ? 1 : 2 ``` ```yaml # .rubocop.yml Style/TernaryParentheses: EnforcedStyle: require_parentheses_when_complex ``` First, auto-corrected by `Style/TernaryParentheses` (`EnforcedStyle: require_parentheses_when_complex`). ```console % bundle exec rubocop -a --only Style/TernaryParentheses Offenses: example.rb:2:1: C: [Corrected] Style/TernaryParentheses: Use parentheses for ternary expressions with complex conditions. !foo.nil? ? 1 : 2 ^^^^^^^^^^^^^^^^^ 1 file inspected, 1 offense detected, 1 offense corrected ``` ```diff % git diff example.rb diff --git a/7716/example.rb b/7716/example.rb index ae08c67..31212d8 100644 --- a/7716/example.rb +++ b/7716/example.rb @@ -1,2 +1,2 @@ # example.rb -!foo.nil? ? 1 : 2 +(!foo.nil?) ? 1 : 2 ``` Next, auto-corrected by `Style/RedundantParentheses`. ```console % bundle exec rubocop -a --only Style/RedundantParentheses Offenses: example.rb:2:1: C: [Corrected] Style/RedundantParentheses: Don't use parentheses around an unary operation. (!foo.nil?) ? 1 : 2 ^^^^^^^^^^^ 1 file inspected, 1 offense detected, 1 offense corrected ``` This will return to the original code. ```diff % git diff example.rb diff --git a/7716/example.rb b/7716/example.rb index 31212d8..ae08c67 100644 --- a/7716/example.rb +++ b/7716/example.rb @@ -1,2 +1,2 @@ # example.rb -(!foo.nil?) ? 1 : 2 +!foo.nil? ? 1 : 2 ``` That caused the infinite loop in `Style/TernaryParentheses` (`EnforcedStyle: require_parentheses_when_complex`) and `Style/RedundantParentheses`. With this PR, `Style/TernaryParentheses` cop makes aware of `Style/RedundantParentheses` cop when setting `EnforcedStyle: require_parentheses_when_complex`. This does the same thing as `EnforcedStyle: require_parentheses` for infinite loop error.
koic
deleted the
fix_an_infinite_loop_error_for_redundant_parentheses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7716.
This PR fixes an infinite loop error for
Style/TernaryParentheseswithStyle/RedundantParentheseswhen usingEnforcedStyle: require_parentheses_when_complex.First, auto-corrected by
Style/TernaryParentheses(EnforcedStyle: require_parentheses_when_complex).Next, auto-corrected by
Style/RedundantParentheses.This will return to the original code.
That caused the infinite loop in
Style/TernaryParentheses(EnforcedStyle: require_parentheses_when_complex) andStyle/RedundantParentheses.With this PR,
Style/TernaryParenthesescop makes aware ofStyle/RedundantParenthesescop when settingEnforcedStyle: require_parentheses_when_complex.This does the same thing as
EnforcedStyle: require_parenthesesfor infinite loop error.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.