Use ConfigLoader.default_configuration for default #7632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanachin
force-pushed
the
fix_rubocop_rails_127
branch
from
ba3aac1
to
15103d4
Compare
When the config file path is same as the default config file, use `ConfigLoader.default_configuration` instead of create a new config. Because some plugins add their default config values to `ConfigLoader.default_configuration`. So the Cops of the plugins expect that default config values exists. Fix rubocop/rubocop-rails#127
hanachin
force-pushed
the
fix_rubocop_rails_127
branch
from
15103d4
to
0533089
Compare
|
@hanachin Sorry for the slow response! The changes look good, but you'll have to rebase on top of |
bbatsov
approved these changes
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the config file path is same as the default config file,
use
ConfigLoader.default_configurationinstead of create a new config.Because some plugins add their default config values to
ConfigLoader.default_configuration. So the Cops of the plugins expectthat default config values exists.
Fix rubocop/rubocop-rails#127
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.