Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration/DepartmentName fails to autocorrect, but says it does #7619

Closed
tas50 opened this issue Jan 3, 2020 · 0 comments · Fixed by #7685
Closed

Migration/DepartmentName fails to autocorrect, but says it does #7619

tas50 opened this issue Jan 3, 2020 · 0 comments · Fixed by #7685

Comments

@tas50
Copy link
Contributor

tas50 commented Jan 3, 2020

Expected behavior

Running: rubocop -a --only Migration/DepartmentName should migrate legacy departments in rubocop comments.

Actual behavior

Cop runs and shows that it autocorrected the department, but did not.

Steps to reproduce the problem

Run rubocop against the followinng code:

# encoding: UTF-8
# rubocop:disable SingleSpaceBeforeFirstArg, Metrics/LineLength
name             "apache_kafka"

RuboCop version

0.78.0
@koic koic mentioned this issue Feb 4, 2020
Merged
8 tasks
koic added a commit to koic/rubocop that referenced this issue Feb 4, 2020
@koic
[Fix rubocop#7619] Support autocorrect of legacy names for `Migration…
dd358d4 
…/DepartmentName`

Fixes rubocop#7619.

This PR supports autocorrect of legacy cop names for
`Migration/DepartmentName`.

Auto-correction for legacy cop names complements legacy department names.
Migration to new cop names are expected to be modified using Gry gem.
https://github.com/pocke/gry
bbatsov pushed a commit that referenced this issue Feb 4, 2020
@koic @bbatsov
[Fix #7619] Support autocorrect of legacy names for `Migration/Depart…
28eb777 
…mentName`

Fixes #7619.

This PR supports autocorrect of legacy cop names for
`Migration/DepartmentName`.

Auto-correction for legacy cop names complements legacy department names.
Migration to new cop names are expected to be modified using Gry gem.
https://github.com/pocke/gry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #7619] Support autocorrect of legacy names for Migration/DepartmentName koic/rubocop
1 participant
@tas50