[Fix #7517] Layout/WhitespaceAroundKeyword: allow super::const
#7518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buehmann
suggested changes
Nov 20, 2019
| @@ -212,10 +217,18 @@ def accept_left_square_bracket?(range) | |||
| ACCEPT_LEFT_SQUARE_BRACKET.include?(range.source) | |||
| end | |||
|
|
|||
| def accept_namesapce_operator?(range) | |||
There was a problem hiding this comment.
Fixed. I already squashed and force pushed it; please let me know if the preference is to use separate commits and squash after approval.
ozydingo
force-pushed
the
layout-space_around_keyword-namespace
branch
from
fadbe21
to
89bb28d
Compare
koic
reviewed
Nov 21, 2019
koic
reviewed
Nov 21, 2019
ozydingo
force-pushed
the
layout-space_around_keyword-namespace
branch
from
89bb28d
to
0a0c442
Compare
koic
approved these changes
Nov 21, 2019
rrosenblum
approved these changes
Nov 21, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Layout/WhitespaceAroundKeywordcop complains whensuper::MyConstis used. However, in Ruby, modules and classes are normal objects and can be returns by methods including by usingsuper. Therefore,super::MyConstshould be considered valid style.This type of usage is distinct from the intention of this cop, which is to avoid missing space such as around
something = 123if testandwhile(something).I considered adding a test that verifies that the cop complains when a keyword other than
superis used in the same manner (it does). However, I believe this is a syntax error in every other case and so the behavior of this cop is perhaps best left undefined. The alternative would be to suggest thatyield ::is the correct form ofyield::, which is false; they're both wrong, and it's not the responsibility of this cop to know that.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.