Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7515] Fix a false negative for Style/RedundantParentheses #7516

Merged

Conversation

koic
Copy link
Member

@koic koic commented Nov 20, 2019

Fixes #7515.

This PR fixes a false negative for Style/RedundantParentheses when calling a method with safe navigation operator.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_a_false_negative_for_style_redundant_parentheses branch 2 times, most recently from 1edaf12 to 26cae51 Compare November 20, 2019 01:18
lib/rubocop/cop/style/redundant_parentheses.rb Outdated Show resolved Hide resolved
lib/rubocop/cop/style/redundant_parentheses.rb Outdated Show resolved Hide resolved
@koic koic force-pushed the fix_a_false_negative_for_style_redundant_parentheses branch from 26cae51 to 2bdf387 Compare November 20, 2019 08:44
Fixes rubocop#7515.

This PR fixes a false negative for `Style/RedundantParentheses` when
calling a method with safe navigation operator.
@koic koic force-pushed the fix_a_false_negative_for_style_redundant_parentheses branch from 2bdf387 to 98ff307 Compare November 22, 2019 04:07
@koic koic merged commit 097a6aa into rubocop:master Nov 22, 2019
@koic koic deleted the fix_a_false_negative_for_style_redundant_parentheses branch November 22, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/RedundantParentheses does not add offense when safe navigation is used.
3 participants