Fix assignment edge-cases in Layout/MultilineAssignmentLayout #7438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
changed the title
gsamokovarov
changed the title
gsamokovarov
force-pushed
the
multiline-assignment-layout-edge-case
branch
2 times, most recently
from
3b11b6e
to
db986cc
Compare
koic
reviewed
Oct 17, 2019
koic
reviewed
Oct 17, 2019
koic
reviewed
Oct 17, 2019
gsamokovarov
force-pushed
the
multiline-assignment-layout-edge-case
branch
from
c8fb49b
to
b200339
Compare
|
This looks good to me. Can you squash your commits into one? |
Assignments from `:[]=` or setter methods (`foo.bar=(value)`) like the ones below did not produce cop reports and were not autocorrected. Now, they are! ```ruby hash[:foo] = if true ^^^^^^^^^^^^^^^^^^^^ Right hand side of multi-line assignment is on the same line as the assignment operator `=`. end ``` ```ruby foo.bar = if true ^^^^^^^^^^^^^^^^^^^^ Right hand side of multi-line assignment is on the same line as the assignment operator `=`. end ```
gsamokovarov
force-pushed
the
multiline-assignment-layout-edge-case
branch
from
b200339
to
d80771d
Compare
|
Done! If everything is fine with the latest build, we will be good to go. |
koic
approved these changes
Oct 17, 2019
|
Thanks always! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignments from
:[]=or setter methods (foo.bar=(value)) like the ones below did not produce cop reports and were not autocorrected. Now, they are!