Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display ABC Metric components with the value #7396

Closed
avmnu-sng opened this issue Oct 3, 2019 · 0 comments
Closed

Display ABC Metric components with the value #7396

avmnu-sng opened this issue Oct 3, 2019 · 0 comments

Comments

@avmnu-sng
Copy link
Contributor

As ABC Metric technically is a size measure (A vector with three orthogonal components), so the magnitude of the vector without its components would never provide any insights over assignments, branches, or, conditions - how would one ever determine which one is the culprit?

Current message:

MSG = 'Assignment Branch Condition size for %s is too high. [%.4g/%.4g]'

I would prefer it being updated to:

MSG = 'Assignment Branch Condition size for %s is too high. [<%d, %d, %d> %.4g/%.4g]'

I felt the need for this when I was writing a story about the complexity metrics in RuboCop.

avmnu-sng added a commit to avmnu-sng/rubocop that referenced this issue Oct 26, 2019
Providing component values gives more insights to fix the offense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant