Autocorrect support for Lint/ErbNewArguments #7219
Assignees
Labels
Comments
koic
added a commit
to koic/rubocop
that referenced
this issue
Jul 19, 2019
Fixes rubocop#7219. This PR supports auto-correct for `Lint/ErbNewArguments`. legacy `trim_mode` arg and legacy `eoutvar` arg take precedence over kwargs. https://github.com/ruby/ruby/blob/v2_7_0_preview1/lib/erb.rb#L821-L828
8 tasks
|
Thanks for the feedback. I opened a PR #7221. |
bbatsov
pushed a commit
that referenced
this issue
Jul 19, 2019
Fixes #7219. This PR supports auto-correct for `Lint/ErbNewArguments`. legacy `trim_mode` arg and legacy `eoutvar` arg take precedence over kwargs. https://github.com/ruby/ruby/blob/v2_7_0_preview1/lib/erb.rb#L821-L828
|
Wow, that was fast! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Lint/ErbNewArgumentscop introduced in #5845 produces messages like "Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments." and "Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: '-') instead."It would be nice if there was an autocorrect to remove the 2nd arg and convert the subsequent ones to kwargs.
The text was updated successfully, but these errors were encountered: