Fix parentheses offence for numeric arguments with an operator #7107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
unary-numeric-omit-parentheses
branch
4 times, most recently
from
d77f29e
to
e5a7aa0
Compare
koic
approved these changes
Jun 5, 2019
rrosenblum
approved these changes
Jun 5, 2019
bbatsov
reviewed
Jun 5, 2019
bbatsov
reviewed
Jun 5, 2019
gsamokovarov
force-pushed
the
unary-numeric-omit-parentheses
branch
from
e5a7aa0
to
70d0109
Compare
In the `Style/MethodCallWithArgsParentheses` cop `omit_parentheses` style, we register an offense for cases like `foo -1` or `foo +1`. This is a potential Ruby warning and an offense from `Lint/AmbiguousOperator`.
gsamokovarov
force-pushed
the
unary-numeric-omit-parentheses
branch
3 times, most recently
from
5b2f5fb
to
b2f6789
Compare
|
@gsamokovarov Looking at the second commit message I think you didn't squash your commits properly. ;-) |
|
Oh, noes! My recent |
gsamokovarov
force-pushed
the
unary-numeric-omit-parentheses
branch
from
b2f6789
to
6789e4a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
Style/MethodCallWithArgsParenthesescopomit_parenthesesstyle, we register an offense for cases like
foo -1orfoo +1. Thisis a potential Ruby warning and an offense from
Lint/AmbiguousOperator.