Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6359] Mark StylePreferredHashMethods as unsafe #7051

Merged
merged 1 commit into from May 17, 2019

Conversation

tejasbubane
Copy link
Contributor

Fixes #6359


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov bbatsov merged commit c89485f into rubocop:master May 17, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented May 17, 2019

Thanks!

@tejasbubane tejasbubane deleted the preferred-hash-unsafe branch May 20, 2019 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/PreferredHashMethods false posive on object that is not a Hash
3 participants