Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #6985] Fix incorrect autocorrect #6986

Merged
merged 1 commit into from Apr 29, 2019
Merged

[Fix #6985] Fix incorrect autocorrect #6986

merged 1 commit into from Apr 29, 2019

Conversation

yakout
Copy link
Contributor

@yakout yakout commented Apr 28, 2019 •
edited

Fixes #6985.

This PR fixes an incorrect auto-correct for Lint/LiteralInInterpolation if contains array percent literals.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@yakout yakout force-pushed the master branch 2 times, most recently from b480cea to 72e9621 Compare April 28, 2019 13:29
Drenmi
Drenmi approved these changes Apr 29, 2019
View reviewed changes
Copy link
Collaborator

@Drenmi Drenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks awesome, thanks! 🚀 Would love to see the name of the cop in the commit message, also. 🙇

@bbatsov bbatsov merged commit 17cdf5a into rubocop:master Apr 29, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 29, 2019

I've updated the commit message before merging the PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drenmi Drenmi Drenmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect auto-correct Lint/LiteralInInterpolation if contains array percent literals
3 participants
@yakout @bbatsov @Drenmi