Style/InverseMethods not being safe in auto-correct

[andreasklinger]

Expected behavior

running Style/InverseMethods should consider return arguments of next statements

Actual behavior

it did change it to a result that's not the same

Steps to reproduce the problem

Simplified example:

class TestClass
  def test_method
    [1, 2, 3, 4].select do |number|
      next(false) if number == 4

      !number.odd?
    end
  end
end

print TestClass.new.test_method

gets autocorrected to

class TestClass
  def test_method
    [1, 2, 3, 4].reject do |number|
      next(false) if number == 4

      number.odd?
    end
  end
end

print TestClass.new.test_method

Which is not the same result:

Console:

$ ruby test_class.rb      
[2]                                                                                                                                                                                     
$ rubocop -a test_class.rb
Inspecting 1 file
C

Offenses:

test_class.rb:3:5: C: [Corrected] Style/InverseMethods: Use reject instead of inverting select.
    [1, 2, 3, 4].select do |number| ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected
$ ruby test_class.rb      
[2, 4]                                                                                                                                                                                  

RuboCop version

$ [bundle exec] rubocop -V
0.67.2 (using Parser 2.6.2.1, running on ruby 2.4.5 x86_64-darwin18)

[Drenmi]

Thanks for the report!

It is likely better if we don't register an offense at all if there's a next present.

[andreasklinger]

@Drenmi i think that's a fair approach 🙌

[dduugg]

Hi, I'd be happy to take fixing this, if no one else is on it already.