Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing absence validations to Rails/Validation #6941

Merged
merged 2 commits into from Apr 17, 2019

Conversation

jmanian
Copy link
Contributor

@jmanian jmanian commented Apr 16, 2019

Rails/Validation is missing the absence validation in its list of validations. (absence is absent.)


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • n/a Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • n/a Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov bbatsov merged commit 0aebdab into rubocop:master Apr 17, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 17, 2019

Thanks!

@jmanian jmanian deleted the jm-rails_absence_validation branch April 17, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants