[Fix #6931] Layout/AccessModifierIndentation outdent style now ignores modifiers with parameters

[deivid-rodriguez]

This is the fix I propose for #6931.

It doesn't include the remane of Layout/AccessModifierIndentation to Layout/BareAccessModifierIndentation though. I can add that if needed.

Before submitting the PR make sure the following are checked:

• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
• The PR relates to only one subject with a clear title
  and description in grammatically correct, complete sentences.
• Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

[bbatsov]

The change looks good to me. Can you confirm it's consistent with how they do things in Rails?

[bbatsov]

One more thing - you can also add some test cases of a modifier being used directly with def.

[deivid-rodriguez]

Thanks for having a look @bbatsov!

Rails doesn't use this cop. They do have Style/IndentationConsistency enabled with EnforcedStyle: Rails style, which still passes after my changes. Is that what you wanted me to check?

Regarding the new tests, I'll add them.

Should I also rename the cop?

[bbatsov]

Should I also rename the cop?

No, I'd rather just update the cop documentation to be more explicit about its scope and what's outside of it.

[deivid-rodriguez]

I tried to clarify the docs a bit, and added a changelog entry. I tagged it as a bug fix. The alternative would be to tag this as a change and change the VersionChanged attribute in the cop, I guess?

[bbatsov]

It's fine as it is. Thanks!

[deivid-rodriguez]

Great, thanks!