Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear messaging on Ruby version check #6793

Closed
elliotcm opened this issue Feb 27, 2019 · 2 comments
Closed

Unclear messaging on Ruby version check #6793

elliotcm opened this issue Feb 27, 2019 · 2 comments
Labels
enhancement good first issue Easy task, suitable for newcomers to the project stale Issues that haven't been active in a while

Comments

@elliotcm
Copy link
Contributor

elliotcm commented Feb 27, 2019

When running an older version of rubocop against a newly released Ruby version, this error is output:

Error: Unknown Ruby version 2.6 found in .ruby-version.

That's fine, but the issue is that when it appears in the normal flow of a linting run it's not clear that rubocop is what's complaining, and it often looks more like e.g. rbenv complaining that the Ruby version isn't installed on the system.

image

Would it be possible to rephrase this in such a way that it's clear that it's rubocop (or a linter in general) that doesn't know about the stated Ruby version so the remedial steps (upgrading rubocop) are clearer to the reader?

I didn't want to open a PR on this one since I didn't know how best you'd want to indicate this, but I'm happy to open one after some feedback on wording.

@Drenmi Drenmi added the good first issue Easy task, suitable for newcomers to the project label Mar 15, 2019
Jakoonce added a commit to Jakoonce/rubocop that referenced this issue Apr 11, 2019
Jakoonce added a commit to Jakoonce/rubocop that referenced this issue Apr 11, 2019
@stale
Copy link

stale bot commented May 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

@stale stale bot added the stale Issues that haven't been active in a while label May 8, 2019
@stale
Copy link

stale bot commented Jun 7, 2019

This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it.

@stale stale bot closed this as completed Jun 7, 2019
tejasbubane added a commit to tejasbubane/rubocop that referenced this issue Jun 19, 2019
Showing it came from `RuboCop`.
bbatsov pushed a commit that referenced this issue Jun 25, 2019
Showing it came from `RuboCop`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Easy task, suitable for newcomers to the project stale Issues that haven't been active in a while
Projects
None yet
Development

No branches or pull requests

2 participants