Add range_type? which means irange_type? and erange_type?
#6773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_range_type_predicate_method
branch
from
3164727
to
c564498
Compare
Follow up of rubocop#6126 (comment). This PR adds `range_type?` method which means both `irange_type?` method and `erange_type?` method.
koic
changed the title
range_type? which means irange_type? and erange_type?`range_type? which means irange_type? and erange_type?
koic
force-pushed
the
add_range_type_predicate_method
branch
from
c564498
to
4105b22
Compare
|
Thanks for your review! |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Apr 29, 2019
Follow up rubocop#6773. This PR refactors with `range_type`.
bbatsov
pushed a commit
that referenced
this pull request
Apr 30, 2019
Follow up #6773. This PR refactors with `range_type`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #6126 (comment).
This PR adds
range_type?method which means bothirange_type?method anderange_type?method.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.