Style/PreferredHashMethods false posive on object that is not a Hash

[jcoyne]

I'm seeing this error:

app/presenters/blacklight/document_presenter.rb:16:40: C: Style/PreferredHashMethods: Use Hash#value? instead of Hash#has_value?.
        render_field?(field_config) && has_value?(field_config)
                                       ^^^^^^^^^^

but the method is not on a hash, it's on a DocumentPresenter.

[Darhazer]

This cop should be marked unsafe, as it could not know whether the receiver is a hash

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[tejasbubane]

@Darhazer Sent a PR to mark it as unsafe.

Apart from this, do you think we should handle the case of no receiver? Calling without receiver most probably means it is not a Hash (unless Hash class is opened).

[Darhazer]

yeah, I guess it doesn't make sense to flag on nil receiver