Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocorrect to TimeZone cop #6346

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Conversation

dcluna
Copy link
Contributor

@dcluna dcluna commented Oct 2, 2018

Add autocorrect to TimeZone cop.
Uses .in_time_zone when possible and .zone when not.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Sorry, something went wrong.

@dcluna dcluna force-pushed the time_zone_autocorrect branch 2 times, most recently from 7f5dbfa to c026f91 Compare October 2, 2018 04:35
@Drenmi
Copy link
Collaborator

Drenmi commented Jan 22, 2019

Hi, @dcluna!

Please rebase this onto latest master and make sure your CHANGELOG entry ends up in the right place, and I think we're good to merge this. Thank you! 🙇

@dcluna dcluna force-pushed the time_zone_autocorrect branch 2 times, most recently from 8025dd8 to 1edd244 Compare January 28, 2019 13:32
@dcluna dcluna force-pushed the time_zone_autocorrect branch from 1edd244 to 20ddc3d Compare February 4, 2019 13:21
@dcluna dcluna force-pushed the time_zone_autocorrect branch from 20ddc3d to 719e4e7 Compare February 8, 2019 22:09
@bbatsov bbatsov merged commit 3417aeb into rubocop:master Mar 14, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 14, 2019

Thanks!

@dcluna dcluna deleted the time_zone_autocorrect branch March 14, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants