BracesAroundHashParameters flagging necessary braces as redundant

[rlue]

In a Rails project, have a hash parameter with a proc as one of its values:

accepts_nested_attributes_for :brands, {
  allow_destroy: true,
  reject_if: proc do |attributes|
    attributes.values_at(:name, :photo, :id).all?(&:blank?)
  end
}

Because of the block used to define the proc, the braces around the hash parameter are necessary. Without them, instantiating this model results in the following error:

>> foo = Account.first
ArgumentError: tried to create Proc object without a block

However, the BracesAroundHashParameters cop is flagging the braces as redundant:

app/models/account.rb:49:42: C: Redundant curly braces around a hash parameter.
  accepts_nested_attributes_for :brands, { ...

Is there another approach / recommended style for this scenario, or is this an issue with the cop?

---

Rubocop v0.51.0, Rails v5.1.4, Ruby 2.4.1p111

[rlue]

Apparently all warnings go away if I use curly braces for the block:

accepts_nested_attributes_for :brands, allow_destroy: true,
                                       reject_if: proc { |attributes|
                                         attributes
                                           .values_at(:name, :photo, :id)
                                           .all?(&:blank?)
                                       }

Rubocop does not raise any warnings for curly braces on a multi-line block here. Is this an accepted/recommended stylistic approach to this case? Is there any chance the aformentioned cop could be modified to detect this issue and make the appropriate style suggestion?

[chuck-john]

I can confirm this behavior. The following throws a Style/BracesAroundHashParameters violation:

... do |app|
  Capybara::Selenium::Driver.new app, {
    browser:              :chrome,
    http_client:          Selenium::WebDriver::Remote::Http::Default.new(read_timeout: 90),
    desired_capabilities: Selenium::WebDriver::Remote::Capabilities.chrome(
	  ...
    )
  }
end

The syntax would be invalid without the curly braces if the first hash key is not moved up one line. Adding the braces should pass the cop in this instance.

environment

• Rubocop 0.54.0
• Ruby 2.4.4

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[rlue]

Bump

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[rlue]

Bump