Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX #4723] RaiseArgs shouldn't autocorrect 3-args form #4725

Conversation

smakagon
Copy link
Contributor

Fixes the auto-correction issue for raise with 3 arguments:

Without this fix, the following code:

begin
  1 / 0
rescue => e
  raise StandardError, 'hi', e.backtrace
end

would be auto-corrected to the broken one:

begin
  1 / 0
rescue => e
  raise StandardError.new('hi', e.backtrace) # wrong number of arguments (given 2, expected 0..1) (ArgumentError)
end

With this fix, any raise with more than 2 arguments will not be autocorrected.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests(rake spec) are passing.
  • The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

end
replacement = "#{node.method_name} #{new_exception}"
replacement = if style == :compact
correction_exploded_to_compact(node)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the unification of the arguments to these sister methods. 👍

@Drenmi
Copy link
Collaborator

Drenmi commented Sep 13, 2017

I think the examples in the class documentation need to be updated. Other than that, all the changes look good! 🚀

@smakagon
Copy link
Contributor Author

@Drenmi Thanks for the review. How would you like to change documentation? Do you want me to add a note for auto-correction behavior?

@Drenmi
Copy link
Collaborator

Drenmi commented Sep 14, 2017

@smakagon: Hm. I thought this invalidated some example in the documentation, but now thinking I might've been wrong. 🙂

@bbatsov bbatsov merged commit c46bf72 into rubocop:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants