Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v1.42.0 #958

Merged
merged 1 commit into from Jul 9, 2020
Merged

Bump version to v1.42.0 #958

merged 1 commit into from Jul 9, 2020

Conversation

bquorning
Copy link
Collaborator

As mentioned in #955, the internal API for autocorrections changed in RuboCop v0.87.0 (rubocop/rubocop#7868), and we already have bug reports because of this incompatibility. Fixes #957.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning requested review from pirj and Darhazer July 9, 2020 19:33
@bquorning bquorning marked this pull request as ready for review July 9, 2020 19:33
@@ -2,6 +2,10 @@

## Master (Unreleased)

## 1.42.0 (2020-07-09)

* Update RuboCop dependency to 0.87.0 because of changes to internal APIs. ([@bquorning][], [@Darhazer][])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added @Darhazer because half of my PR was him urging me make less of a mess :-)

Copy link
Member

@Darhazer Darhazer Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than I would need to add you as a co-author of half my contributions. Credits are not deserved here, you did a great job with the update!

@bquorning bquorning merged commit cd69228 into master Jul 9, 2020
@bquorning bquorning deleted the release branch July 9, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VariableName cop raises "undefined method `loc'"
2 participants