Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Andrew to the hall of fame #928

Merged
merged 1 commit into from Jun 11, 2020
Merged

Conversation

pirj
Copy link
Member

@pirj pirj commented Jun 11, 2020

For his work on #925


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@pirj pirj self-assigned this Jun 11, 2020
For his incredible work on #925
@pirj pirj force-pushed the add-andry-to-hall-of-fame branch from 50535b5 to 686b1a8 Compare June 11, 2020 09:21
@pirj pirj requested review from Darhazer and bquorning June 11, 2020 09:21
@@ -77,7 +77,7 @@ class SubjectStub < Cop

def on_block(node)
return unless example_group?(node)
return unless (processed_example_groups & node.ancestors).empty?
return if (processed_example_groups & node.ancestors).any?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁 ❤️

@@ -94,7 +94,7 @@ def processed_example_groups
end

def find_all_explicit_subjects(node)
node.each_descendant(:block).each_with_object({}) do |child, h|
node.each_descendant(:block).with_object({}) do |child, h|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today I learned about with_object. Hadn’t noticed that alias before. And it’s been there since 2.4‽

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bquorning bquorning merged commit 5d8f75d into master Jun 11, 2020
@bquorning bquorning deleted the add-andry-to-hall-of-fame branch June 11, 2020 09:28
@bquorning bquorning mentioned this pull request Jun 11, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants