Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.40.0 #927

Merged
merged 1 commit into from Jun 11, 2020
Merged

Bump version to 1.40.0 #927

merged 1 commit into from Jun 11, 2020

Conversation

bquorning
Copy link
Collaborator

Please double check:

  • Did I miss any new process re. VersionAdded/VersionChanged?
  • Do we have any PRs that should be merged before cutting a release?

Changelog since last release:

  • Add new RSpec/VariableName cop. (@tejasbubane)
  • Add new RSpec/VariableDefinition cop. (@tejasbubane)
  • Expand Capybara/VisibilityMatcher to support more than just have_selector. (@twalpole)
  • Add new SpecSuffixOnly option to RSpec/FilePath cop. (@zdennis)
  • Allow RSpec/RepeatedExampleGroupBody to differ only by described_class. (@robotdana)
  • Fix RSpec/FilePath detection across sibling directories. (@rolfschmidt)
  • Substantial performance inprovement of RSpec/SubjectStub. (@andrykonchin)

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning
Copy link
Collaborator Author

Rebased after #928.

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

Pushed a small amendment for FilePath since we've introduced a config option there. I believe it's completely optional since we didn't change the defaults though. We'll figure out the exact procedure as we go.

On the other hand, it might be of interest for those who update to be notified about those new options. Or may be a burden. Not sure yet.

config/default.yml Outdated Show resolved Hide resolved
@Darhazer
Copy link
Member

When new options are introduced, even if default are not changed, we should bump the VersionChanged. At some point we could point the users to the new options, so they can tweak their configurations. For now I think we only point them to newly added cops.

@bquorning
Copy link
Collaborator Author

Thank you, both.

@bquorning bquorning merged commit ddf9694 into master Jun 11, 2020
@bquorning bquorning deleted the release branch June 11, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants