Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 1.39.0 #906

Merged
merged 1 commit into from May 1, 2020
Merged

Bump version to 1.39.0 #906

merged 1 commit into from May 1, 2020

Conversation

bquorning
Copy link
Collaborator

@bquorning bquorning commented May 1, 2020 •
edited

Changelog since last release:

  • Fix RSpec/FilePath detection when absolute path includes test subject. (@eitoball)
  • Add new Capybara/VisibilityMatcher cop. (@aried3r)
  • Ignore String constants by RSpec/Describe. (@AlexWayfer)
  • Drop support for ruby 2.3. (@bquorning)
  • Fix multiple cops to detect let with proc argument. (@tejasbubane)
  • Add autocorrect support for RSpec/ScatteredLet. (@Darhazer)
  • Add new RSpec/EmptyHook cop. (@tejasbubane)

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the changelog if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning requested review from pirj and Darhazer May 1, 2020 09:55
@bquorning bquorning marked this pull request as ready for review May 1, 2020 09:55
Darhazer
Darhazer approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@Darhazer Darhazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good to be back in the changelog list :)

@bquorning bquorning merged commit f1956ae into master May 1, 2020
@bquorning bquorning deleted the release branch May 1, 2020 10:30
@pirj
Copy link
Member

pirj commented May 1, 2020

I feel quite sad about not participating in this release much.

pirj
pirj reviewed May 1, 2020
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bquorning
Copy link
Collaborator Author

I feel quite sad about not participating in this release much.

Take it easy. You have reviewed every single pull request that makes up this release. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj left review comments

@Darhazer Darhazer Darhazer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bquorning @pirj @Darhazer