Fix multiple cops to detect let with proc argument
#904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejasbubane
commented
Apr 29, 2020
|
WDYT of adding |
Makes sense, this might simplify lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb |
@Darhazer could you open a new issue for that? Or maybe a PR to showcase the change. |
|
Sure 👍 |
|
@bquorning @Darhazer I added |
Affected cops: 1. `RSpec/ScatteredLet` 2. `RSpec/AlignLeftLetBrace` 3. `RSpec/AlignRightLetBrace` 4. `RSpec/LeadingSubject` 5. `RSpec/EmptyLineAfterFinalLet` 6. `RSpec/LetBeforeExamples` Closes rubocop#771
tejasbubane
changed the title
RSpec/ScatteredLet to detect let with proc argumentlet with proc argument
|
@pirj Added specs for those other cops as well. |
bquorning
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
could you open a new issue for that? Or maybe a PR to showcase the change.
I was clearly confused when I wrote that comment. Of course “the change” belongs in this PR. Thanks you for the bugfix and Language module improvements @tejasbubane 🚀
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #771
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).