Scattered let autocorrect #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Darhazer FYI the build failed. |
jonatas
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Very cool @Darhazer ! I was thinking that maybe we could inherit Layout/ClassStructure and provide some RSpec/Structure with the defaults in the proper order. I remember when we opted by swapping the nodes and it would automatically adjust the spacing because the nodes do not hold the spaces.
|
@bquorning fixed. Sorry, I wanted to share the code with a colleague and forgot to actually run the rake task |
Darhazer
force-pushed
the
scattered-let-autocorrect
branch
from
1afc5b3
to
1d9615b
Compare
pirj
approved these changes
Apr 28, 2020
| corrector.remove(node_range_with_surrounding_space(node)) | ||
| RuboCop::RSpec::Corrector::MoveNode.new( | ||
| node, corrector, processed_source | ||
| ).move_before(first_example) |
| @@ -12,6 +12,76 @@ | |||
| ^^^^^^^^^^^^^ Group all let/let! blocks in the example group together. | |||
| end | |||
| RUBY | |||
|
|
|||
| expect_correction(<<-RUBY) | |||
| RSpec.describe User do | |||
|
|
||
| end | ||
| end | ||
| RUBY | ||
| end |
There was a problem hiding this comment.
Just in case, maybe add an example for let!?
|
Possible conflict with #904 – or at least there’s an extra test case to autocorrect. |
Darhazer
force-pushed
the
scattered-let-autocorrect
branch
from
1d9615b
to
9941338
Compare
|
Updated |
bquorning
approved these changes
Apr 29, 2020
pirj
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that we don't have an autocorrect support for scattered let, but it's quite easy to do, as we already move nodes around.
I also refactored the autocorrect part, as I had to copy/paste 3 methods one more time, and we had enough copies already.
It seems that rubocop-rspec deals with the structure much more than rubocop itself - I found only one cop there that would benefit from the new helper, that's why I left it as part of rubocop-rspec instead.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.