Replace should-example with expect-example
#899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoral
force-pushed
the
replace_should_style_example_for_named_subject
branch
from
f275bba
to
f97a88b
Compare
pirj
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
It's so hard to keep up to have canonical code even in the comments.
Build failure is unrelated and will be fixed in #901
Funny enough that is_expected that is better than should is used as a "bad" example.
Thanks for your contribution!
bquorning
approved these changes
Apr 27, 2020
pirj
force-pushed
the
replace_should_style_example_for_named_subject
branch
from
f97a88b
to
ff6b291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docs for
RSpec/NamedSubjectwe useshould-style example as a good one. Sinceexpect-style is a modern and enforced one, I guess it would be more correct to useexpect-style examples.Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).