Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relaxes rubocop-ast dependency locking #1047

Merged
merged 1 commit into from Oct 20, 2020
Merged

Relaxes rubocop-ast dependency locking #1047

merged 1 commit into from Oct 20, 2020

Conversation

PhilCoggins
Copy link
Contributor

@PhilCoggins PhilCoggins commented Oct 20, 2020 •
edited by pirj

Relaxes rubocop-ast dependency lock from ~> 0.7.1 to ~> 0.7, fixes #1046

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • Added the new cop to config/default.yml.
  • The cop is configured as Enabled: pending in config/default.yml.
  • The cop documents examples of good and bad code.
  • The tests assert both that bad code is reported and that good code is not reported.
  • Set VersionAdded in default/config.yml to the next minor version.

If you have modified an existing cop's configuration options:

  • Set VersionChanged in config/default.yml to the next major version.

pirj
pirj approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

rubocop-rspec.gemspec Outdated
@@ -37,7 +37,7 @@ Gem::Specification.new do |spec|
}

spec.add_runtime_dependency 'rubocop', '~> 0.87'
spec.add_runtime_dependency 'rubocop-ast', '~> 0.7.1'
spec.add_runtime_dependency 'rubocop-ast', '~> 0.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a specific reason to use 0.7.1 as opposed to 0.7.0. But I guess ~> 0.7 is good either way, and bundler will install 0.7.1+ unless 0.7.0 is already installed.

I hope this explicit dependency specification statement will go away when RuboCop and rubocop-ast hit 1.0, and we hit 2.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After giving it another thought, let's write it as >= 0.7.1, since 0.7.1 released this fix for JRuby.

@pirj
Copy link
Member

pirj commented Oct 20, 2020 •
edited

@bquorning Any chance for a minor patch release?

@PhilCoggins
Copy link
Contributor Author

This seems to fail with rubocop-ast 0.8.0, probably want to hold off on merging until that gets figured out. https://app.circleci.com/pipelines/github/rubocop-hq/rubocop-rspec/579/workflows/7af23933-9e4f-434b-9c88-5992c5f1f60c/jobs/17591

@bquorning
Copy link
Collaborator

This seems to fail with rubocop-ast 0.8.0

It only fails against edge rubocop (they’re making ready for v1.0). The other specs pass, also when using rubocop-ast 0.8.0 – e.g. https://app.circleci.com/pipelines/github/rubocop-hq/rubocop-rspec/580/workflows/2d22b1ca-ade8-4e41-a49d-50c80cc3a608/jobs/17602

@bquorning bquorning merged commit e7dc4d4 into rubocop:master Oct 20, 2020
@PhilCoggins PhilCoggins deleted the relax_rubocop_ast_dependency branch October 20, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version conflict for rubocop-rspec 1.44.0 with rubocop-ast 0.8
3 participants
@PhilCoggins @pirj @bquorning