Bump version to 1.44.0 #1045
Merged
Bump version to 1.44.0 #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add a spec to check the contributors list in the Changelog.
Darhazer
approved these changes
Oct 20, 2020
I merged 🤦 |
|
Not a big deal. I recall that the process is manual, this means that we don't yet have the changes published. But eventually, they will be. Not sure if we need to ping someone to publish the docs. |
|
Ah, here it is: #972 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pirj mentioned in #1018 (comment) that maybe it was time for a new release.
I am still unsure of the new release process for our documentation, so please don’t merge before we’ve figured that out 😄
By the way, sorry for doing two things in one pull request, but I added a spec to check the looks of the contributors list in the changelog file.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).