Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language::SelectorSet tweaks #1041

Merged
merged 2 commits into from Oct 16, 2020
Merged

Language::SelectorSet tweaks #1041

merged 2 commits into from Oct 16, 2020

Conversation

marcandre
Copy link
Contributor

I wanted to access [:subject, :subject!] and was surprised to realize I couldn't.

This PR addresses that.

Commits are not directly related, but second one assumes first one. Let me know if I need to split them.

@pirj pirj requested a review from Darhazer October 16, 2020 12:46
pirj
pirj approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections.
We've changed a lot in #956, do those changes need to be repeated there as well?

@marcandre
Copy link
Contributor Author

I have no objections.
We've changed a lot in #956, do those changes need to be repeated there as well?

No, I don't think so, rspec_keywords exposes those values.

Darhazer
Darhazer approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@Darhazer Darhazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side

@pirj pirj merged commit e11f6e3 into rubocop:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirj pirj pirj approved these changes

@Darhazer Darhazer Darhazer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcandre @pirj @Darhazer