Skip files with shared groups in RSpec/FilePath #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://relishapp.com/rspec/rspec-core/docs/example-groups/shared-examples states that shared groups don't have to have the _spec.rb suffix, and even preferably omit _spec.
|
@fabioxgn Please let me know if this fix resolves the issue you are experiencing. |
pirj
commented
Aug 19, 2020
| @@ -16,7 +16,7 @@ def on_new_investigation | |||
| return unless root_node | |||
|
|
|||
| top_level_groups.each do |node| | |||
| example_group?(node, &method(:on_top_level_example_group)) | |||
There was a problem hiding this comment.
It turns out example_group? was yielding nil as there's no capture.
It does! Thanks. |
bquorning
approved these changes
Aug 20, 2020
Darhazer
approved these changes
Aug 21, 2020
bquorning
pushed a commit
that referenced
this pull request
Aug 24, 2020
…shared-groups Skip files with shared groups in RSpec/FilePath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://relishapp.com/rspec/rspec-core/docs/example-groups/shared-examples states that shared groups don't have to have the _spec.rb suffix, and even preferably omit _spec.
Fixes #1008
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).