Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ActiveRecord/Aliases as unsafe autocorrect #98

Merged
merged 1 commit into from Aug 1, 2019

Conversation

prathamesh-sonpatki
Copy link
Contributor

@prathamesh-sonpatki prathamesh-sonpatki commented Jul 30, 2019

We faced an issue where our custom update_attributes method call was changed to update but the method name remained same in the method definition.

Original code

def update_attributes
end

update_attributes

After running rubocop --safe-auto-correct:

def update_attributes
end

update

So the cop is not safe for auto correct.

Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

config/default.yml Outdated Show resolved Hide resolved
@koic
Copy link
Member

koic commented Jul 30, 2019

Could you add a changelog entry? I think the following is an example.
rubocop/rubocop#6613

@prathamesh-sonpatki prathamesh-sonpatki changed the title Make ActiveRecordAliases scope false Mark ActiveRecordAliases as unsafe autocorrect Jul 30, 2019
@prathamesh-sonpatki prathamesh-sonpatki changed the title Mark ActiveRecordAliases as unsafe autocorrect Mark ActiveRecord/Aliases as unsafe autocorrect Jul 30, 2019
@prathamesh-sonpatki
Copy link
Contributor Author

@koic Thanks, done!

config/default.yml Outdated Show resolved Hide resolved
Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for your quick response!

CHANGELOG.md Outdated Show resolved Hide resolved
We faced an issue where our custom `update_attributes` method call was changed to `update` but the method name remained same in the method definition.

```ruby
def update_attributes
end

update_attributes
```

```ruby
def update_attributes
end

update
```

So the cop is not safe for auto correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants