Change default of EnforcedStyle to slashes for Rails/FilePath
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes default of `EnforcedStyle` from `arguments` to `slashes` for `Rails/FilePath`. The following is why `slashes` by default. - `Rails.root` is an instance of `Pathname`, so the separator (`/`) works for example on the Windows platform. - Since it can be expressed by a single string, the number of string instances can be reduced. - Clarified because the argument is fixed to one. `EnforcedStyle`'s default was `arguments` because it was mainly due to Windows platform considerations, but it seems to have been a mistake. rubocop#128 (comment)
koic
force-pushed
the
enforce_style_slashes_by_default
branch
from
5d08ea3
to
dd92d31
Compare
no-reply
pushed a commit
to samvera/bixby
that referenced
this pull request
Jun 10, 2020
don't try to make existing projects change this. they have already changed all these to match the old enforced style, and the only reason for the change is to "reduce the number of string instances". rubocop/rubocop-rails#141
bess
pushed a commit
to samvera/bixby
that referenced
this pull request
Jun 10, 2020
don't try to make existing projects change this. they have already changed all these to match the old enforced style, and the only reason for the change is to "reduce the number of string instances". rubocop/rubocop-rails#141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes default of
EnforcedStylefromargumentstoslashesforRails/FilePath.The following is why
slashesby default.Rails.rootis an instance ofPathname, so the separator (/) works for example on the Windows platform.EnforcedStyle's default wasargumentsbecause it was mainly due to Windows platform considerations, but it seems to have been a mistake.#128 (comment)
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.