Fix a false negative for Performance/RegexpMatch
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up rubocop/rubocop#5569. This PR fixes a false negative for `Performance/RegexpMatch` when `MatchData` is not detected in `if` branch of guard condition. ```console % cat example.rb # frozen_string_literal: true raise unless ex.message =~ /can't modify frozen IOError/ % bundle exec rubocop --only Performance/RegexpMatch Inspecting 1 file . 1 file inspected, no offenses detected ``` This issue was detected by the following code. https://github.com/rails/rails/blob/v6.0.0.rc2/actioncable/test/client_test.rb#L94
Follow up rubocop/rubocop#5569 (comment). This commit fixes a false positive for `Performance/RegexpMatch` when `MatchData` exists after guard condition. The following is an example code with false positive. ```ruby def foo return if /re/ =~ str # `Regexp.last_match[1]` cannot be referenced if changed from `=~` to `match?`. do_something(Regexp.last_match[1]) end ```
|
This PR still has the following problem. I will work on this. % cd path/to/rails/rails # https://github.com/rails/rails
% bundle exec rubocop activerecord/lib/arel/visitors/oracle.rb --only Performance/RegexpMatch -d
For /Users/koic/src/github.com/rails/rails: configuration from /Users/koic/src/github.com/rails/rails/.rubocop.yml
configuration from /Users/koic/src/github.com/rubocop-hq/rubocop-performance/config/default.yml
configuration from /Users/koic/src/github.com/rubocop-hq/rubocop-performance/config/default.yml
Default configuration from /Users/koic/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rubocop-0.71.0/config/default.yml
configuration from /Users/koic/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rubocop-rails-2.0.0/config/default.yml
configuration from /Users/koic/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rubocop-rails-2.0.0/config/default.yml
Inspecting 1 file
Scanning /Users/koic/src/github.com/rails/rails/activerecord/lib/arel/visitors/oracle.rb
An error occurred while Performance/RegexpMatch cop was inspecting /Users/koic/src/github.com/rails/rails/activerecord/lib/arel/visitors/oracle.rb:125:51.
undefined method `if_branch' for #<RuboCop::AST::BlockNode:0x00007fedd7303d48>
/Users/koic/src/github.com/rubocop-hq/rubocop-performance/lib/rubocop/cop/performance/regexp_match.rb:207:in `block in next_match_pos'
/Users/koic/src/github.com/rubocop-hq/rubocop-performance/lib/rubocop/cop/performance/regexp_match.rb:127:in `block in search_match_nodes' |
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Jul 28, 2019
Follow up rubocop#73 (comment). This commit fixes an error for `Performance/RegexpMatch` when a regexp used independently with a regexp used in `if` are mixed.
|
I fixed the above error. |
Follow up rubocop#73 (comment). This commit fixes an error for `Performance/RegexpMatch` when a regexp used independently with a regexp used in `if` are mixed.
koic
force-pushed
the
fix_false_negative_for_performance_regexp_match
branch
from
7a41f99
to
12fc7fb
Compare
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Sep 9, 2019
* Use RuboCop Performance 1.4.1 * Refer rubocop/rubocop-performance#61 and/or rubocop/rubocop-performance#73 ```ruby $ bundle exec rubocop -a Inspecting 66 files ..........C..C..C......C.................C........................ Offenses: lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb:68:21: C: [Corrected] Performance/RegexpMatch: Use match? instead of =~ when MatchData is not used. return if sql =~ /FROM all_/ ^^^^^^^^^^^^^^^^^^ lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb:241:26: C: [Corrected] Performance/RegexpMatch: Use match? instead of =~ when MatchData is not used. raise unless e.message =~ /^(Closed Connection|Io exception:|No more data to read from socket|IO Error:)/ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb:321:35: C: [Corrected] Performance/RegexpMatch: Use match? instead of =~ when MatchData is not used. host = "[#{host}]" if host =~ /^[^\[].*:/ # IPv6 ^^^^^^^^^^^^^^^^^^^ lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb:323:46: C: [Corrected] Performance/RegexpMatch: Use match? instead of match when MatchData is not used. database = "/#{database}" unless database.match(/^\//) ^^^^^^^^^^^^^^^^^^^^^ lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb:650:46: C: [Corrected] Performance/RegexpMatch: Use match? instead of =~ when MatchData is not used. field["data_default"] = nil if field["data_default"] =~ /^(null|empty_[bc]lob\(\))$/i ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb:183:58: C: [Corrected] Performance/RegexpMatch: Use match? instead of match when MatchData is not used. params[:database] = "/#{params[:database]}" unless params[:database].match(/^\//) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 66 files inspected, 6 offenses detected, 6 offenses corrected $ ```
renawatson68
added a commit
to renawatson68/performance-develop-rubyonrails
that referenced
this pull request
Sep 23, 2022
Follow up rubocop/rubocop-performance#73 (comment). This commit fixes an error for `Performance/RegexpMatch` when a regexp used independently with a regexp used in `if` are mixed.
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this pull request
Nov 4, 2022
Follow up rubocop/rubocop-performance#73 (comment). This commit fixes an error for `Performance/RegexpMatch` when a regexp used independently with a regexp used in `if` are mixed.
MarttiCheng
added a commit
to MarttiCheng/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
Follow up rubocop/rubocop-performance#73 (comment). This commit fixes an error for `Performance/RegexpMatch` when a regexp used independently with a regexp used in `if` are mixed.
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
Follow up rubocop/rubocop-performance#73 (comment). This commit fixes an error for `Performance/RegexpMatch` when a regexp used independently with a regexp used in `if` are mixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop#5569.
This PR fixes a false negative for
Performance/RegexpMatchwhenMatchDatais not detected inifbranch of guard condition.This issue was detected by the following code.
https://github.com/rails/rails/blob/v6.0.0.rc2/actioncable/test/client_test.rb#L94
That is a feedback that @kamipo gave. Thank you.
And follow up rubocop/rubocop#5569 (comment).
This PR prevents a false positive for
Performance/RegexpMatchwhenMatchDataexists after guard condition.The following is an example code with false positive.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.