Don't autocorrect BigDecimal with float when precision is specified #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
approved these changes
Jul 11, 2020
The precision argument to `BigDecimal()` is ignored unless the value is
a float or rational. Converting the value from a float to a string when
a precision is specified changes the result.
$ ruby -rbigdecimal -e "puts BigDecimal(3.14, 1)"
0.3e1
$ ruby -rbigdecimal -e "puts BigDecimal('3.14', 1)"
0.314e1
eugeneius
force-pushed
the
bigdecimal_float_precision
branch
from
22478ee
to
80bbdab
Compare
|
Rebased ✅ |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The precision argument to
BigDecimal()is ignored unless the value is a float or rational. Converting the value from a float to a string when a precision is specified changes the result.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.