Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Performance/ReverseEach #201

Merged

Conversation

koic
Copy link
Member

@koic koic commented Dec 18, 2020

Fixes standardrb/standard#230.

This PR fixes the following incorrect auto-correct for Performance/ReverseEach when using multi-line reverse.each with leading dot.

% cat example.rb
[1, 2, 3]
  .reverse
  .each do |idx|
    puts idx
  end

Before

% bundle exec rubocop -a --only Performance/ReverseEach
% cat example.rb
[1, 2, 3]
  .reverse
  _each do |idx|
    puts idx
  end

After

% bundle exec rubocop -a --only Performance/ReverseEach
% cat example.rb
[1, 2, 3]
  .reverse_each do |idx|
    puts idx
  end

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes standardrb/standard#230.

This PR fixes the following incorrect auto-correct for `Performance/ReverseEach`
when using multi-line `reverse.each` with leading dot.

```ruby
% cat example.rb
[1, 2, 3]
  .reverse
  .each do |idx|
    puts idx
  end
```

## Before

```console
% bundle exec rubocop -a --only Performance/ReverseEach
% cat example.rb
[1, 2, 3]
  .reverse
  _each do |idx|
    puts idx
  end
```

## After

```console
% bundle exec rubocop -a --only Performance/ReverseEach
% cat example.rb
[1, 2, 3]
  .reverse_each do |idx|
    puts idx
  end
```
@koic koic merged commit 56147bc into rubocop:master Dec 21, 2020
@koic koic deleted the fix_incorrect_autocorrect_for_reverse_each branch December 21, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken reverse_each autocorrect
1 participant