New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect replacement recommendation for `Performance/ChainArrayAllocation` #196

Merged

koic merged 1 commit into rubocop:master from fatkodima:fix-chain-array-allocation-offense

Nov 23, 2020

Contributor

fatkodima commented Nov 23, 2020 •

edited

Closes #185

The real change is this line - https://github.com/rubocop-hq/rubocop-performance/pull/196/files#diff-aadc09c37851b4bcdde6d9af4f194ba5bd2578117e64170d87d2174e17772a63R52

Other changes are a small refactoring rewriting a patterns with %CONST feature.


          Fix incorrect replacement recommendation for `Performance/ChainArrayA…

04bffd6

…llocation`

Contributor

marcandre commented Nov 23, 2020

Nice refactoring. So the bug was simply a typo, then...

koic merged commit d460877 into rubocop:master

Member

koic commented Nov 23, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment