[Fix #165] Fix a false positive for Performance/Sum
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
reviewed
Sep 5, 2020
lib/rubocop/cop/performance/sum.rb
Outdated
| @@ -98,7 +98,7 @@ def build_good_method(init) | |||
|
|
|||
| unless init.empty? | |||
| init = init.first | |||
| good_method += "(#{init.source})" if init.source.to_i != 0 | |||
| good_method += "(#{init.source})" unless init.int_type? && init.source.to_i.zero? | |||
There was a problem hiding this comment.
init.source.to_i.zero? => init.value.zero?
There was a problem hiding this comment.
It's definitely simple. Thank you for your review!
Fixes rubocop#165. This PR fixes a false positive for `Performance/Sum` when using initial value argument is a variable.
koic
force-pushed
the
fix_false_positive_for_performance_sum
branch
from
9a6654a
to
61578d9
Compare
marcandre
approved these changes
Sep 5, 2020
|
Thanks, @koic! |
|
@mvz You are welcome. Thank you for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165.
This PR fixes a false positive for
Performance/Sumwhen using initial value argument is a variable.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.