Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node#left_sibling, right_sibling, left_siblings and right_siblings #93

Merged
merged 1 commit into from Aug 11, 2020
Merged

Add Node#left_sibling, right_sibling, left_siblings and right_siblings #93

merged 1 commit into from Aug 11, 2020

Conversation

marcandre
Copy link
Contributor

@marcandre marcandre changed the title Add Node#left_sibling, right_sibling, left_siblings and rigft_siblings Add Node#left_sibling, right_sibling, left_siblings and right_siblings Aug 10, 2020
@marcandre marcandre mentioned this pull request Aug 10, 2020
Merged
@fatkodima
Copy link
Contributor

👍
I think, just siblings may also be useful too.

@marcandre
Copy link
Contributor Author

marcandre commented Aug 10, 2020 •
edited

👍
I think, just siblings may also be useful too.

as in left_siblings + right_siblings? Do we have such uses?

@fatkodima
Copy link
Contributor

Haven't find any, but maybe, mayyybeee (😄 ) it will be needed in the future.

@marcandre marcandre merged commit 96b0656 into rubocop:master Aug 11, 2020
@marcandre
Copy link
Contributor Author

So I merged this, if we see a lot of left_siblings + right_siblings, we'll add siblings...

@fatkodima fatkodima mentioned this pull request Sep 16, 2020
Merged
koic added a commit to rubocop/rubocop-rails that referenced this pull request Jul 9, 2021
@koic
Use Node#left_sibling(s) and Node#right_sibling(s)
2e73f21 
Follow up to rubocop/rubocop-ast#93.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcandre @fatkodima