Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Parser::Ruby28 #48

Merged
merged 1 commit into from Jun 25, 2020
Merged

Support Parser::Ruby28 #48

merged 1 commit into from Jun 25, 2020

Conversation

koic
Copy link
Member

@koic koic commented Jun 25, 2020

Parser gem has been started development for Ruby 2.8 (edge Ruby).
whitequark/parser#677

This PR supports Parser::Ruby28, the early adapters will be able to try edge Ruby with RuboCop.

I will open a PR later to new Ruby 2.8 (3.0) syntax supported by Parser.

Parser gem has been started development for Ruby 2.8 (edge Ruby).
whitequark/parser#677

This PR supports `Parser::Ruby28`, the early adapters will be able to
try edge Ruby with RuboCop.

I will open a PR later to new Ruby 2.8 (3.0) syntax supported by Parser.
@marcandre marcandre merged commit 4377a64 into rubocop:master Jun 25, 2020
@marcandre
Copy link
Contributor

👍 😄

@koic koic deleted the support_ruby_28 branch June 25, 2020 15:11
@bbatsov
Copy link
Contributor

bbatsov commented Jun 25, 2020

I guess we need to cut a new rubocop-ast release now.

@marcandre
Copy link
Contributor

I can take care of it. Let me merge #35.
Maybe we could include #29 too...

@marcandre
Copy link
Contributor

I'll also add a note that 2.8 support is experimental until that version is actually released.

@marcandre
Copy link
Contributor

v0.1.0 released 🎉

koic added a commit to koic/rubocop that referenced this pull request Jun 26, 2020
This PR permits to specify TargetRubyVersion 2.8.

RuboCop AST supports Ruby 2.8 (3.0) with
rubocop/rubocop-ast#48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants