Add delimiters' and related predicates for RegexpNode`
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jun 16, 2020
| @@ -32,6 +32,11 @@ def content | |||
| children.select(&:str_type?).map(&:str_content).join | |||
| end | |||
|
|
|||
| # @return [Bool] if char is one of the delimiters | |||
| def delimiter?(char) | |||
There was a problem hiding this comment.
I guess you can also add a delimiters method that returns the two of them and implement this one in terms of it.
There was a problem hiding this comment.
Good idea - I took a quick look for related predicates used by RuboCop, so added those too, let me know what you think
bbatsov
approved these changes
Jun 16, 2020
|
Great work! |
bbatsov
reviewed
Jun 16, 2020
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| * [#20](https://github.com/rubocop-hq/rubocop-ast/pull/20): Add option predicates for `RegexpNode`. ([@owst][]) | |||
| * [#11](https://github.com/rubocop-hq/rubocop-ast/issues/11): Add `argument_type?` method to make it easy to recognize argument nodes. ([@tejasbubane][]) | |||
| * [#31](https://github.com/rubocop-hq/rubocop-ast/pull/31): Use `param === node` to match params, which allows Regexp, Proc, Set, etc. ([@marcandre][]) | |||
| * [#41](https://github.com/rubocop-hq/rubocop-ast/pull/41): Add `delimiters' and related predicates for `RegexpNode`. ([@owst][]) | |||
There was a problem hiding this comment.
You've made a small mistake with the backticks here.
owst
changed the title
delimiter?' predicate for RegexpNode`delimiters' and related predicates for RegexpNode`
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @bbatsov here:
rubocop/rubocop#8138 (comment)