Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pattern method for AST::InPatternNode #186

Merged

Conversation

koic
Copy link
Member

@koic koic commented May 28, 2021

This PR adds pattern method for AST::InPatternNode.

This PR adds `pattern` method for `AST::InPatternNode`.
@marcandre marcandre merged commit cc96aa8 into rubocop:master May 28, 2021
@koic koic deleted the add_pattern_method_for_ast_in_pattern_node branch May 28, 2021 16:58
@marcandre
Copy link
Contributor

Thanks! Release in 1.7.0 👍

@koic
Copy link
Member Author

koic commented May 28, 2021

Wow! Thank you for your quick release!

koic added a commit to koic/rubocop that referenced this pull request May 29, 2021
This PR adds new `Style/InPatternThen` cop.
It checks for `in;` uses in `case` expressions.

```ruby
# bad
case expression
in pattern_a; foo
in pattern_b; bar
end

# good
case expression
in pattern_a then foo
in pattern_b then bar
end
```

This cop is similar to `Style/WhenThen`, but with different supported
syntax and Ruby version (requires 2.7 or higher).

And this PR use rubocop/rubocop-ast#186 feature,
so it requires RuboCop AST 1.7.0 or higher.
bbatsov pushed a commit to rubocop/rubocop that referenced this pull request May 30, 2021
This PR adds new `Style/InPatternThen` cop.
It checks for `in;` uses in `case` expressions.

```ruby
# bad
case expression
in pattern_a; foo
in pattern_b; bar
end

# good
case expression
in pattern_a then foo
in pattern_b then bar
end
```

This cop is similar to `Style/WhenThen`, but with different supported
syntax and Ruby version (requires 2.7 or higher).

And this PR use rubocop/rubocop-ast#186 feature,
so it requires RuboCop AST 1.7.0 or higher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants