Have def_modifier? return the def node or nil instead of boolean
#171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
changed the title
def_modifier. Improve doc.def_modifier? return the def node or nil instead of boolean
marcandre
force-pushed
the
def_modifier
branch
3 times, most recently
from
e733be0
to
cb28d03
Compare
|
@bbatsov Should I create a different method without the |
|
Or maybe @dvandersluis ? |
|
I don't have a strong opinion here but it probably makes more sense to not be a predicate method if its return method is purposefully an actual object, otherwise it's kind of a side effect. |
|
I agree. I'd introduce a new method named |
|
Ok, PR changed accordingly 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.