Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Parser::Ruby28 to Parser::Ruby30 for Ruby 3.0 parser #121

Merged
merged 1 commit into from Sep 24, 2020

Conversation

koic
Copy link
Member

@koic koic commented Sep 24, 2020

Parser 2.7.1.5 includes whitequark/parser#729 and this PR updates from Parser::Ruby28 to Parser::Ruby30 for Ruby 3.0 parser.

@koic
Copy link
Member Author

koic commented Sep 24, 2020

This PR should be synchronized with rubocop/rubocop#8785 for the successful build.

@koic
Copy link
Member Author

koic commented Sep 24, 2020

@bbatsov @marcandre Can you please release RuboCop AST with this PR merged to resolve rubocop/rubocop#8785?

when 2.8
require 'parser/ruby28'
Parser::Ruby28
when 3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we have when 2.8, 3.0 for compatibility?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I get it. In the future, the syntax of Ruby 2.8 and Ruby 3.0 may be dissociated, but I think they are almost the same now. It seems better that both are still supported as migration path. I updated this one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this way we are compatible with older rubocop who know about 2.8 and not about 3.0. There won't be an actual Ruby 2.8 afaik.

Parser 2.7.1.5 includes whitequark/parser#729 and
this PR updates from `Parser::Ruby28` to `Parser::Ruby30` for Ruby 3.0 parser.
@marcandre
Copy link
Contributor

And yes, I will make a release shortly, I would like to also merge 2 other PRs too.

@koic koic force-pushed the update_from_28_to_30_parser branch from d84f39d to d466792 Compare September 24, 2020 17:31
@marcandre marcandre merged commit 4adf4b2 into rubocop:master Sep 24, 2020
@koic koic deleted the update_from_28_to_30_parser branch September 24, 2020 17:43
@marcandre
Copy link
Contributor

Released 0.5.0 👍

@koic
Copy link
Member Author

koic commented Sep 24, 2020

Thank you for your quick releasing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants