Fix macro? #120
Merged
Fix macro? #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
force-pushed
the
fix_macro_p
branch
3 times, most recently
from
b434fb8
to
39a0929
Compare
|
Blocked by rubocop/rubocop#8789, rubocop/rubocop#8791 and #123 馃挦 |
marcandre
force-pushed
the
fix_macro_p
branch
3 times, most recently
from
d067ec9
to
1607269
Compare
Bump minimum compatibility with main gem.
marcandre
force-pushed
the
fix_macro_p
branch
from
1607269
to
e31b2a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes rubocop/rubocop#8765
There were many issues with how
macro_scope?:ifdid not distinguish if in the conditions part or on of the bodiesIt also introduces
Node#parent?Builds on #119
I'll do a final review when I'm less sleepy 馃槄